[doc beta] ember-views & ember-glimmer rfc176 & doc updates #16168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're good. EventDispatcher still gets namespaced with E ber |
toddjordan
reviewed
Jan 25, 2018
| @@ -29,7 +29,7 @@ import { String as StringUtils } from 'ember-runtime'; | |||
| </div> | |||
| ``` | |||
|
|
|||
| See [Ember.String.loc](/api/classes/Ember.String.html#method_loc) for how to | |||
| See [Ember.String.loc](/api/ember/release/classes/String/methods/loc?anchor=loc) for how to | |||
There was a problem hiding this comment.
Change from Ember.String.loc to String.loc
|
@Parrryy thanks! Now it just looks like all that's left is to rebase in the latest master to get rid of the conflict, then squash the files and prepend |
Assert for forgetting .get() on an Ember proxy updated to new release links and some rfc176 doc updates
Parrryy
force-pushed
the
ember-views-and-glimmer-package-doc-update
branch
from
2cde57e
to
ca26163
Compare
|
The first time, rebasing and had lots of issues so made a new branch and PR. It won't happen again, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #15723 for following packages:
ember-viewsember-glimmerCouldn't find a replacement for
Ember.EventDispatcher, let me know if there is one so I can change it.